[PATCH] D64286: [LFTR] Don't use post-inc IV unless already used

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 10:48:24 PDT 2019


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2407
+  // LSR. Converting to post-inc now may require dropping poison flags.
+  bool UsePostInc = ExitingBB == L->getLoopLatch() &&
+                    isLoopExitTestBasedOn(IncVar, ExitingBB);
----------------
It occurs to me that checks other than the latch might already be in post-inc form.  Maybe we should leave them that way?  (Definitely a separate change.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64286/new/

https://reviews.llvm.org/D64286





More information about the llvm-commits mailing list