[PATCH] D64353: [AMDGPU] Run '' after isel to simplify PHIs.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

I think you should probably fix SILowerControlFlow



================
Comment at: llvm/test/CodeGen/AMDGPU/lcssa-optnone.ll:1-3
+; RUN: llc -march=amdgcn -O0 -o - %s | FileCheck %s
+
+; CHECK-LABEL: non_uniform_loop
----------------
hliao wrote:
> arsenm wrote:
> > Generate check lines
> that test case crash with the fix. I added CHECK-LABEL to check codegen could pass. Checking the code generated seems unnecessary to me.
Tests with no checks are bad form. I think any tests related to control flow handling should probably just be generated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64353/new/

https://reviews.llvm.org/D64353