[PATCH] D64060: [LoopInfo] Extend getExitEdges API

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 10:07:08 PDT 2019


reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Given all the other APIs on this class work in terms of BlockT*, not const BlockT*, I think it would be more consistent to just change the definition of Edge in this case.  The one caller should be trivial to update.

In theory, being const correct is better, but consistency in the code overrides to me.

If you want to make the suggested change to Edge, feel free to submit without further review.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64060/new/

https://reviews.llvm.org/D64060





More information about the llvm-commits mailing list