[PATCH] D64037: [IR][PatternMatch] introduce m_Unless() matcher
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 09:57:00 PDT 2019
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: unittests/IR/PatternMatch.cpp:89
+TEST_F(PatternMatchTest, Unless) {
+ Value *One = IRB.CreateAdd(IRB.getInt32(1), IRB.getInt32(0));
+
----------------
Better to call this value 'X' or some other non-overlapping name - easy to misread 'm_One' and 'One' below here.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64037/new/
https://reviews.llvm.org/D64037
More information about the llvm-commits
mailing list