[PATCH] D64353: [AMDGPU] Run '' after isel to simplify PHIs.
    Michael Liao via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Jul  8 09:56:58 PDT 2019
    
    
  
hliao added a comment.
In D64353#1573837 <https://reviews.llvm.org/D64353#1573837>, @arsenm wrote:
> I don't follow how eliminating unreachable blocks fixes this.
>
> In general expecting code placement with the block "prolog" instructions isn't reliable. I had fixed this in rL357634 <https://reviews.llvm.org/rL357634>, except it was reverted
BTW, the flow created by CFG structurizer should not have PHI at all by design.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64353/new/
https://reviews.llvm.org/D64353
    
    
More information about the llvm-commits
mailing list