[PATCH] D64205: [X86][SSE] EltsFromConsecutiveLoads - add basic dereferenceable support

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 07:58:52 PDT 2019


niravd added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:7603
+  // elements.
+  if (FirstLoadedElt == 0 &&
+      (LastLoadedElt == (int)(NumElems - 1) || IsDereferenceable) &&
----------------
Any reason that FirstLoadedElt must be zero if IsDereferenceable? I didn't see anything beyond the CreateLoad where that predicate could be relocated.

It'd be nice if we could pull the first/last checks up into the IsDereferenceable definition.




Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64205/new/

https://reviews.llvm.org/D64205





More information about the llvm-commits mailing list