[PATCH] D64318: Make sret parameter work with AddMissingPrototypes
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 8 03:44:38 PDT 2019
aheejin updated this revision to Diff 208359.
aheejin added a comment.
- Use `llvm::any_of`
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64318/new/
https://reviews.llvm.org/D64318
Files:
lib/Target/WebAssembly/WebAssemblyAddMissingPrototypes.cpp
test/CodeGen/WebAssembly/add-prototypes.ll
Index: test/CodeGen/WebAssembly/add-prototypes.ll
===================================================================
--- test/CodeGen/WebAssembly/add-prototypes.ll
+++ test/CodeGen/WebAssembly/add-prototypes.ll
@@ -56,6 +56,17 @@
ret void
}
+; Check if a sret parameter works in a no-prototype function.
+; CHECK-LABEL: @sret_param
+; CHECK: call void @make_struct_foo(%struct.foo* sret %foo)
+%struct.foo = type { i32, i32 }
+declare void @make_struct_foo(%struct.foo* sret, ...) #1
+define void @sret_param() {
+ %foo = alloca %struct.foo, align 4
+ call void bitcast (void (%struct.foo*, ...)* @make_struct_foo to void (%struct.foo*)*)(%struct.foo* sret %foo)
+ ret void
+}
+
declare void @func_param(i64 (...)*)
; CHECK: declare void @func_not_called()
Index: lib/Target/WebAssembly/WebAssemblyAddMissingPrototypes.cpp
===================================================================
--- lib/Target/WebAssembly/WebAssemblyAddMissingPrototypes.cpp
+++ lib/Target/WebAssembly/WebAssemblyAddMissingPrototypes.cpp
@@ -78,10 +78,15 @@
report_fatal_error(
"Functions with 'no-prototype' attribute must take varargs: " +
F.getName());
- if (F.getFunctionType()->getNumParams() != 0)
- report_fatal_error(
- "Functions with 'no-prototype' attribute should not have params: " +
- F.getName());
+ if (F.getFunctionType()->getNumParams() != 0) {
+ auto isNonSretArg = [](const Argument &Arg) {
+ return !Arg.hasStructRetAttr();
+ };
+ if (llvm::any_of(F.args(), isNonSretArg))
+ report_fatal_error("Functions with 'no-prototype' attribute should "
+ "not have params: " +
+ F.getName());
+ }
// Create a function prototype based on the first call site (first bitcast)
// that we find.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64318.208359.patch
Type: text/x-patch
Size: 1849 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190708/2c80f272/attachment.bin>
More information about the llvm-commits
mailing list