[PATCH] D64315: [lld][WebAssembly] Fix typo in error message

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 02:34:33 PDT 2019


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL365304: [lld][WebAssembly] Fix typo in error message (authored by sbc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D64315?vs=208337&id=208338#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64315/new/

https://reviews.llvm.org/D64315

Files:
  lld/trunk/test/wasm/undefined-data.ll
  lld/trunk/wasm/Relocations.cpp


Index: lld/trunk/test/wasm/undefined-data.ll
===================================================================
--- lld/trunk/test/wasm/undefined-data.ll
+++ lld/trunk/test/wasm/undefined-data.ll
@@ -13,6 +13,6 @@
     ret i32 %0
 }
 
-; UNDEF: undefined symbol: data_external
-; ALLOW: undefined-data.ll.tmp.o: cannot resolve relocation of type R_WASM_MEMORY_ADDR_LEB against undefined (non-weak) data symbol: data_external
-; SHARED: undefined-data.ll.tmp.o: relocation R_WASM_MEMORY_ADDR_LEB cannot be used againt symbol data_external; recompile with -fPIC
+; UNDEF: error: {{.*}}undefined-data.ll.tmp.o: undefined symbol: data_external
+; ALLOW: error: {{.*}}undefined-data.ll.tmp.o: cannot resolve relocation of type R_WASM_MEMORY_ADDR_LEB against undefined (non-weak) data symbol: data_external
+; SHARED: error: {{.*}}undefined-data.ll.tmp.o: relocation R_WASM_MEMORY_ADDR_LEB cannot be used against symbol data_external; recompile with -fPIC
Index: lld/trunk/wasm/Relocations.cpp
===================================================================
--- lld/trunk/wasm/Relocations.cpp
+++ lld/trunk/wasm/Relocations.cpp
@@ -69,7 +69,7 @@
         // Certain relocation types can't be used when building PIC output,
         // since they would require absolute symbol addresses at link time.
         error(toString(File) + ": relocation " + relocTypeToString(Reloc.Type) +
-              " cannot be used againt symbol " + toString(*Sym) +
+              " cannot be used against symbol " + toString(*Sym) +
               "; recompile with -fPIC");
         break;
       case R_WASM_TABLE_INDEX_I32:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64315.208338.patch
Type: text/x-patch
Size: 1610 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190708/b108a3a7/attachment.bin>


More information about the llvm-commits mailing list