[PATCH] D64306: [clangd] Use xxhash instead of SHA1 for background index file digests.

Kadir Cetinkaya via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 8 01:42:21 PDT 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM.

Out of curiosity what was the use case yielded the profile? I hope it is a use case with a lot of loading from disk storage, and only a few indexing operations?
Because in that case we're mostly IO bound, but if it is the other way around and this pops up as a 10% percent cpu usage, while we're performing (CPU bound) indexing part, it definitely sounds scary and something else might be wrong.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64306/new/

https://reviews.llvm.org/D64306





More information about the llvm-commits mailing list