[PATCH] D64297: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

[Manuel Klimek via Phabricator via llvm-commits]

klimek added a comment.

In D64297#1572872 <https://reviews.llvm.org/D64297#1572872>, @MaskRay wrote:

> Is `distcc gcc.exe` or `gomacc gcc.exe` possible?
>
> > The design of the compilation database/plugin model makes it pretty hard to add options.
>
> Yes. It also lacks user settings. Downstream `compile_commands.json` consumers may provide their own command line option filtering mechanism that users can customize and add more compiler schedulers. For some tools, they probably don't want to see filtering applying on multiple layers, especially if the filtering mechanism done at the JSONCompilationDatabase layer may have false positives.


Do you have examples of things that would break with this filtering applied?

>> but a messy aspect of the nature of the ecosystem around compile_commands.json.
> 
> I'll appreciate it if you propose something to make `cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=On` `ninja -t comdb` etc more precise:)

I think that's a somewhat different scope than this patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64297/new/

https://reviews.llvm.org/D64297