[PATCH] D64121: Rename variables so that they start with a lowercase letter.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 4 06:15:35 PDT 2019
jhenderson added a comment.
Herald added a subscriber: wuzish.
FWIW, I skimmed through the first few files (up to the end of the Arch directory), and broadly am happy with it, but I do agree that "is" is not a good variable name, and would prefer it to be iSec or inputSec or something like that (I'd suggest inSec, but that is too predicate-like for my looking).
I definitely agree with a variable name change list this. I'd be happy with the underscore version too, though would personally think that should be for function names at least.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64121/new/
https://reviews.llvm.org/D64121
More information about the llvm-commits
mailing list