[PATCH] D64121: Rename variables so that they start with a lowercase letter.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

Thanks for the updates. I've scanned through the whole patch and only 2 things jumped out at me and they are minor and subjective; I've put comments inline. It is certainly possible that I missed something, but overall I think that this is good enough and we could fix up any other mistakes later on.



================
Comment at: lld/ELF/AArch64ErrataFix.cpp:503
           break;
-        (*PatchIt)->OutSecOff = PrevISLimit;
-        ++PatchIt;
+        (*patchIt)->outSecOff = prevISLimit;
+        ++patchIt;
----------------
ISLimit has gone to isecLimit. Could we make prevISLimit go to prevIsecLimit?


================
Comment at: lld/ELF/InputSection.h:355
   // Used by ICF.
-  uint32_t Class[2] = {0, 0};
+  uint32_t klass[2] = {0, 0};
 
----------------
I think this is the only use of Class in LLD. Given that it is the equivalence class could this be made eClass or eqClass?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64121/new/

https://reviews.llvm.org/D64121