[PATCH] D62120: [ORC] fix unreachable code bug

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

In D62120#1511073 <https://reviews.llvm.org/D62120#1511073>, @nickdesaulniers wrote:

> Wouldn't just deleting L142 from the existing sources be simpler? (or moving L146-148 into the for loop at the end (L142)?


Moving 146/148 into the loop gets you "map cleared on success but not on error" behavior, which is what I had intended. I have made that change in r361199, so I will close this out.

My thoughts above were on how to get "Optionally cleared on error" behavior, which I think is useful. Implementing that can wait for another day though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62120/new/

https://reviews.llvm.org/D62120