[PATCH] D64268: [MIPS GlobalISel] Register bank select for G_STORE. Select i64 store

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.

LGTM with a few code-style nits.



================
Comment at: lib/Target/Mips/MipsRegisterBankInfo.cpp:297
+    unsigned Size = MRI.getType(MI.getOperand(0).getReg()).getSizeInBits();
+    unsigned InstTy = InstType::Integer;
+    if (!MRI.getType(MI.getOperand(0).getReg()).isPointer()) {
----------------
Is it possible to use `InstType` instead of `unsigned` here?


================
Comment at: lib/Target/Mips/MipsRegisterBankInfo.cpp:419
+
+class InstManager : public GISelChangeObserver {
+  InstListTy &InstList;
----------------
Let's put this class into anonymous namespace.


================
Comment at: lib/Target/Mips/MipsRegisterBankInfo.cpp:482
+}
\ No newline at end of file

----------------
Restore new line at the end of this file.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64268/new/

https://reviews.llvm.org/D64268