[PATCH] D64245: [docs][llvm-objcopy] Add description of binary input/output to doc

Fri Jul 5 20:27:26 PDT 2019

abrachet accepted this revision.
abrachet added a comment.
This revision is now accepted and ready to land.

LGTM

================
Comment at: docs/CommandGuide/llvm-objcopy.rst:466
+
+If ``binary`` is used as the value for :option:`--input-target`, the input file
+will be embedded as a data section in an ELF relocatable object, with symbols
----------------
This is super nit, and I'm not sure if either way is correct. But it seems like known option arguments use one back tick and then the user specified flags like <filename> use two. See --add-symbol on line 170 and --compress-debug-sections on line 221. If we follow those then 'binary' should only be with single back ticks. Of course line 460 uses the double back ticks though. I don't think it makes a huge difference either way just thought I would bring this up.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64245/new/

https://reviews.llvm.org/D64245