[PATCH] D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.
This revision is now accepted and ready to land.

LGTM with minor comments.



================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:768
+  // get placed into this csect. The choice of csect name is not a property of
+  // the ABI or object file format. For example the XL compiler uses an unnamed
+  // csect for program code.
----------------
Minor nit: Add a comma after "[f]or example".


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-basic.ll:17
+; NOTE: The object file output and the assembly file output do not describe the
+;       same abstract XCOFF content due to the limited amount of functionallity
+;       implemented.
----------------
s/functionallity/functionality/;


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-basic.ll:35
+
+; The csect does not need to be present, but llvm's defualt behavior when
+; emitting asm is to start the file with the .text section.
----------------
s/llvm's defualt/LLVM's default/;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61694/new/

https://reviews.llvm.org/D61694