[PATCH] D64227: [FileCheck] Fix comment in parseNumericVariableUse

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 05:03:35 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL365192: [FileCheck] Fix comment in parseNumericVariableUse (authored by thopre, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D64227?vs=208094&id=208153#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64227/new/

https://reviews.llvm.org/D64227

Files:
  llvm/trunk/lib/Support/FileCheck.cpp


Index: llvm/trunk/lib/Support/FileCheck.cpp
===================================================================
--- llvm/trunk/lib/Support/FileCheck.cpp
+++ llvm/trunk/lib/Support/FileCheck.cpp
@@ -151,12 +151,12 @@
     return FileCheckErrorDiagnostic::get(
         SM, Name, "invalid pseudo numeric variable '" + Name + "'");
 
-  // This method is indirectly called from parsePattern for all numeric
-  // variable definitions and uses in the order in which they appear in the
-  // CHECK pattern. For each definition, the pointer to the class instance of
-  // the corresponding numeric variable definition is stored in
-  // GlobalNumericVariableTable. Therefore, the pointer we get below is for the
-  // class instance corresponding to the last definition of this variable use.
+  // Numeric variable definitions and uses are parsed in the order in which
+  // they appear in the CHECK patterns. For each definition, the pointer to the
+  // class instance of the corresponding numeric variable definition is stored
+  // in GlobalNumericVariableTable in parsePattern. Therefore, the pointer we
+  // get below is for the class instance corresponding to the last definition
+  // of this variable use.
   auto VarTableIter = Context->GlobalNumericVariableTable.find(Name);
   if (VarTableIter == Context->GlobalNumericVariableTable.end())
     return FileCheckErrorDiagnostic::get(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64227.208153.patch
Type: text/x-patch
Size: 1390 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190705/51251b8a/attachment.bin>


More information about the llvm-commits mailing list