[PATCH] D64226: [FileCheck] Factor some parsing checks out

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-defines-diagnostics.txt:23
 
-NUMERRCLITRAIL: Global defines:1:20: error: invalid variable name
+NUMERRCLITRAIL: Global defines:1:25: error: unexpected characters after numeric variable name
 NUMERRCLITRAIL-NEXT: Global define #1: #VALUE+2=10
----------------
arichardson wrote:
> jhenderson wrote:
> > It's slightly disconcerting that the column number here has changed. I assume that it's just some difference between the start and end of the string or something?
> It seems like the diagnostic now points to the invalid character (+) instead of the start of the name. I think this makes more sense.
As Alexander said, it was pointing to the start of the variable before (saying basically that the whole "VALUE+2" is an invalid variable name) and is now pointing to the + operator because that's the first unexpected character.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64226/new/

https://reviews.llvm.org/D64226