[PATCH] D64228: [FileCheck] Don't diagnose undef vars at parse time

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:72
 ; Numeric expression using undefined variable.
-RUN: not FileCheck --check-prefix UNDEF-USE --input-file %s %s 2>&1 \
-RUN:   | FileCheck --strict-whitespace --check-prefix UNDEF-USE-MSG %s
+RUN: not FileCheck --check-prefix UNDEF-USE --input-file %s %s
 
----------------
jhenderson wrote:
> Have you lost test coverage here? It looks to me like you're no longer checking the error message printed at all, and I don't understand why from your comment.
I checked llvm/test/FileCheck/verbose.txt and thought it was already tested there but looking at it again today it's clearly not the case. Shouldn't have submitted those patches so late. The codepath is tested via llvm/test/FileCheck/var-scope.txt but (1) not the full diagnostic is checked for (only the error message) and (2) this only checks undefined variable due to --enable-var-scope.

I've recycled the test for undefined numeric variables, I'll submit a separate patch later to add a test for undefined string variables.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64228/new/

https://reviews.llvm.org/D64228