[PATCH] D64230: [FileCheck] Record numeric variable availability

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

As mentioned inline, I don't understand what you mean by "available". Perhaps you could post some basic examples for the different cases explaining what you mean, and then I can try suggesting some different terminology.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:52
 
-  /// Line number where this variable is defined. Used to determine whether a
-  /// variable is defined on the same line as a given use.
-  size_t DefLineNumber;
+  /// Line number where this variable's value becomes available.
+  size_t AvailLineNumber;
----------------
I'm not sure it's clear to me what "available" means in this context if it doesn't mean definition.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:56
 public:
-  /// Constructor for a variable \p Name defined at line \p DefLineNumber.
-  FileCheckNumericVariable(size_t DefLineNumber, StringRef Name)
-      : Name(Name), DefLineNumber(DefLineNumber) {}
-
-  /// Constructor for numeric variable \p Name with a known \p Value at parse
-  /// time (e.g. the @LINE numeric variable).
-  FileCheckNumericVariable(StringRef Name, uint64_t Value)
-      : Name(Name), Value(Value), DefLineNumber(0) {}
+  /// Constructor for a numeric variable \p Name defined from a value in input
+  /// and whose value becomes available at line \p AvailLineNumber.
----------------
in input -> in the input (?)


================
Comment at: llvm/include/llvm/Support/FileCheck.h:58
+  /// and whose value becomes available at line \p AvailLineNumber.
+  FileCheckNumericVariable(StringRef Name, size_t AvailLineNumber)
+      : Name(Name), AvailLineNumber(AvailLineNumber) {}
----------------
Not that I'm bothered really, but is there a reason to change the signature order here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64230/new/

https://reviews.llvm.org/D64230