[PATCH] D64229: [FileCheck] Share variable instance among uses

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 01:37:50 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Thanks! I think this makes more sense now too. LGTM.



================
Comment at: llvm/lib/Support/FileCheck.cpp:260
+    Expected<FileCheckNumericVariable *> ParseResult =
+        parseNumericVariableDefinition(DefExpr, Context, this->LineNumber, SM);
+    if (!ParseResult)
----------------
Nit: is `this` required here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64229/new/

https://reviews.llvm.org/D64229





More information about the llvm-commits mailing list