[PATCH] D61907: [RISCV] Leave pcrel_hi/pcrel_lo fixup pairs unresolved

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 01:32:11 PDT 2019


asb added inline comments.
Herald added subscribers: Jim, MaskRay.


================
Comment at: test/MC/RISCV/linker-relaxation.s:125
 addi t1, t1, %pcrel_lo(2b)
-# NORELAX-RELOC-NOT: R_RISCV_PCREL_LO12_I
+# NORELAX-RELOC: R_RISCV_PCREL_LO12_I bar 0x4
 # NORELAX-RELOC-NOT: R_RISCV_RELAX
----------------
asb wrote:
> Shouldn't be this be `.Ltmp1 0x0` just like in the RELAX-RELOC case?
Hi Lewis, did you have any thoughts on this?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61907/new/

https://reviews.llvm.org/D61907





More information about the llvm-commits mailing list