[PATCH] D64226: [FileCheck] Factor some parsing checks out

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, assuming the error position difference is not an issue.



================
Comment at: llvm/lib/Support/FileCheck.cpp:251
+    DefinedNumericVariable =
+        Context->makeNumericVariable(this->LineNumber, Name);
+
----------------
Nit: is `this` needed here?


================
Comment at: llvm/test/FileCheck/numeric-defines-diagnostics.txt:23
 
-NUMERRCLITRAIL: Global defines:1:20: error: invalid variable name
+NUMERRCLITRAIL: Global defines:1:25: error: unexpected characters after numeric variable name
 NUMERRCLITRAIL-NEXT: Global define #1: #VALUE+2=10
----------------
It's slightly disconcerting that the column number here has changed. I assume that it's just some difference between the start and end of the string or something?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64226/new/

https://reviews.llvm.org/D64226