[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lib/Target/RISCV/RISCVMachineFunctionInfo.cpp:27
+  // function uses a varargs save area.
+  if (VarArgsSaveSize != 0)
+    return false;
----------------
MaskRay wrote:
> `return EnableSaveRestore && VarArgsSaveSize == 0;` ?
Oh, why can't this stub just be inlined into getUseSaveRestoreLibCalls? It can be trivially computed every time its value is used. You can expand it later if this function ever becomes more complex.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62686/new/

https://reviews.llvm.org/D62686