[PATCH] D63859: [Support] Add getFileOrSTDIN which calls a callback if stdin is a tty

Alex Brachet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 00:00:59 PDT 2019


abrachet abandoned this revision.
abrachet added a comment.

> I am a bit dubious about the change. Why is a callback needed? Doesn't performing operations in the call sites meet your needs?

Yeah I think you two are right. It is better perform that check outside of this function when its needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63859/new/

https://reviews.llvm.org/D63859





More information about the llvm-commits mailing list