[PATCH] D64236: [llvm-objcopy] Don't change permissions of non-regular output files

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: abrachet, alexshap, jakehehrlich, jhenderson, rupprecht.
Herald added subscribers: llvm-commits, kristina, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This fixes the EPERM error when a regular user executes `llvm-objcopy a.o /dev/null`

A new overload of llvm::sys::fs::setPermissions is added.
Users should provide `perm & ~umask` as the parameter if they intend to
respect umask.


Repository:
  rL LLVM

https://reviews.llvm.org/D64236

Files:
  include/llvm/Support/FileSystem.h
  lib/Support/Unix/Path.inc
  lib/Support/Windows/Path.inc
  test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test
  tools/llvm-objcopy/llvm-objcopy.cpp
  unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64236.208120.patch
Type: text/x-patch
Size: 6035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190705/fa99283d/attachment.bin>