[PATCH] D64006: [Support] Support 64-bit offsets in DataExtractor.

Thu Jul 4 08:06:39 PDT 2019

ikudrin added a comment.

In D64006#1568894 <https://reviews.llvm.org/D64006#1568894>, @dblaikie wrote:

> > In that case, what do you think about templates?
>
> They help, for sure - though I I'm not sure it's probably necessary to have even that complexity (having DataExtractor templated on an integer type for the cursor), at least I don't see it yet, maybe with better understanding I might - but for now it really sounds like we would've built this with uint64_t only if we started from scratch.

D64209 <https://reviews.llvm.org/D64209> demonstrates how I see using templates for that task. Which way for these temporary patches do you prefer?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64006/new/

https://reviews.llvm.org/D64006