[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro marked an inline comment as done.
djtodoro added a comment.

>> The 'llvm-dwarfdump' does calculate the debug location statistics, but maybe we could think of reporting it with more information, since the debug location info is such important debug info. Please find a proposal for having a separate tool that will calculate only the debug location statistics on my github (https://github.com/djolertrk/llvm-locstats) and let me know if it can be useful for us. Potentially, we could add more options, functionalities, etc..



> That seems like a useful tool!

Thanks a lot for taking a look!

> Did you consider what should be done with llvm-dwarfdump's "scope bytes covered" statistics?

I think that it sounds reasonable to add an additional field there, something like "non-entry-val scope bytes covered".



================
Comment at: lib/CodeGen/LiveDebugValues.cpp:169
+        if (Kind != EntryValueKind)
+          Kind = RegisterKind;
         Loc.RegNo = RegNo;
----------------
dstenb wrote:
> djtodoro wrote:
> > aprantl wrote:
> > > This looks dangerous.. are entry values somehow implicitly also register values? Iguess besed on the other patches the answer is yes, but that also means that we must `assert((!EntryValueKind || RegNo) && "entry values must be register locations")`
> > Yes, you are right! Thanks!
> I think this should be `Kind != EntryValueKind`?
Oh, nice catch! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042