[PATCH] D64206: [llvm\test\Object] - An initial step to cleanup the test cases.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 06:43:37 PDT 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added a subscriber: aheejin.
grimar edited the summary of this revision.

This patch removes trivial-object-test.elf-i386,
trivial-object-test.elf-x86-64 and trivial-object-test2.elf-x86-64
precompiled objects from test/Object/Inputs folder.

I adjusted the existent test cases to use YAML instead.

Notes:

1. I tried not no change the check lines and sections/symbol names.

But I reduced the YAMLs produces from these objects significantly.

2. It was not my intention to add any comments, so I did not do that.

(see 3)

3. Most of these tests are not on their places. I think many of them

should be moved to `test/tools/llvm-nm`, `test/tools/objdump` and so on.
Perhaps some of them can be removed, I guess they are duplicating the existent
tests in the folders mentioned.

I did not try to resolve 1-3 here, because this patch is already probably
too hard to read/review and such cleanups should be done in a follow-ups.

I would like to get rid of precompiled objects at first.


https://reviews.llvm.org/D64206

Files:
  test/Object/Inputs/trivial-object-test.elf-i386
  test/Object/Inputs/trivial-object-test.elf-x86-64
  test/Object/Inputs/trivial-object-test2.elf-x86-64
  test/Object/X86/objdump-disassembly-inline-relocations.test
  test/Object/X86/objdump-trivial-object.test
  test/Object/archive-symtab.test
  test/Object/mri-addmod.test
  test/Object/nm-error.test
  test/Object/nm-shared-object.test
  test/Object/nm-trivial-object.test
  test/Object/obj2yaml.test
  test/Object/objdump-file-header.test
  test/Object/objdump-relocations.test
  test/Object/objdump-section-content.test
  test/Object/objdump-sectionheaders.test
  test/Object/objdump-symbol-table.test
  test/Object/readobj-absent.test
  test/Object/readobj.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64206.208024.patch
Type: text/x-patch
Size: 152889 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190704/fa2ff123/attachment-0001.bin>


More information about the llvm-commits mailing list