[PATCH] D64200: [ELF] Allow placing non-string SHF_MERGE sections with different alignments into the same MergeSyntheticSection

[Fangrui Song via Phabricator via llvm-commits]

MaskRay updated this revision to Diff 208022.
MaskRay edited the summary of this revision.
MaskRay added a comment.

Update description

The root cause is clear now.

  MergeTailSection::MergeTailSection(StringRef Name, uint32_t Type,
                                     uint64_t Flags, uint32_t Alignment)
      : MergeSyntheticSection(Name, Type, Flags, Alignment),
        Builder(StringTableBuilder::RAW, Alignment) {}

Builder::Alignment was out of sync if we update MergeTailSection::Alignment.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64200/new/

https://reviews.llvm.org/D64200

Files:
  ELF/SyntheticSections.cpp
  test/ELF/merge-align2.s
  test/ELF/merge-entsize2.s
  test/ELF/merge-reloc-O0.s
  test/ELF/tail-merge-string-align2.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64200.208022.patch
Type: text/x-patch
Size: 6210 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190704/f45cea85/attachment.bin>