[PATCH] D64136: [ELF] resolveUndefined: ignore undefined symbols in SharedFile for Undefined and SharedSymbol

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/Symbols.cpp:485
+  // Undefined symbols in a SharedFile do not change the binding.
+  if (isa_and_nonnull<SharedFile>(Other.File))
+    return;
----------------
Little off-topic, but I'd probably just use dyn_cast instead of this new predicate so that code readers don't have to memorize one more predicate.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64136/new/

https://reviews.llvm.org/D64136