[PATCH] D64130: [LLD][ELF] - Linkerscript: add a support for expressions for section's filling

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/ScriptLexer.cpp:195
+    // Get the operator as a token.
+    // Keep !=, ==, >=, <=, << and >> operators as a single tokens.
+    if (S.substr(E).startswith("!=") || S.substr(E).startswith("==") ||
----------------
MaskRay wrote:
> arichardson wrote:
> > This seems unrelated, maybe split it out into a separate patch?
> I think tokenizeExpr() did not have to be precise before because readOutputSectionDescription() did not consume tokens that can be prefixed of ==, <<, <=, >= and >> (i.e. =, <, >). Now it did so a preciser tokenizeExpr is needed.
> 
> I think keeping the change here is probably fine.
Yes, this is needed for this patch to work (after adding only `=` a few of our other test start failing).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64130/new/

https://reviews.llvm.org/D64130