[PATCH] D63614: [System Model] [TTI] Update cache and prefetch TTI interfaces
Hal Finkel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 3 23:04:23 PDT 2019
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
I'd prefer we remove the redundant comments in TTIImpl.h (see below), but otherwise, LGTM.
================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:390
- unsigned getMinPrefetchStride() { return 1; }
+ /// \return The minimum stride in bytes where it makes sense to
+ /// start adding SW prefetches. Some HW prefetchers can handle
----------------
I don't see any value in repeating these interface comments here. They're already present on the declarations in TargetTransformInfo.h, and they'll get out of sync here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63614/new/
https://reviews.llvm.org/D63614
More information about the llvm-commits
mailing list