[PATCH] D64166: [ASan] Use __sanitizer_fill_shadow for FastPoisonShadow on Fuchsia

[Petr Hosek via Phabricator via llvm-commits]

phosek created this revision.
phosek added reviewers: mcgrathr, eugenis, kcc.
Herald added subscribers: llvm-commits, Sanitizers, kubamracek.
Herald added projects: LLVM, Sanitizers.

This is the optimized implementation for Fuchsia provided by the libc.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D64166

Files:
  compiler-rt/lib/asan/asan_poisoning.h


Index: compiler-rt/lib/asan/asan_poisoning.h
===================================================================
--- compiler-rt/lib/asan/asan_poisoning.h
+++ compiler-rt/lib/asan/asan_poisoning.h
@@ -15,6 +15,7 @@
 #include "asan_internal.h"
 #include "asan_mapping.h"
 #include "sanitizer_common/sanitizer_flags.h"
+#include "sanitizer_common/sanitizer_platform.h"
 
 namespace __asan {
 
@@ -38,6 +39,10 @@
 ALWAYS_INLINE void FastPoisonShadow(uptr aligned_beg, uptr aligned_size,
                                     u8 value) {
   DCHECK(!value || CanPoisonMemory());
+#if SANITIZER_FUCHSIA
+  __sanitizer_fill_shadow(aligned_beg, aligned_size, value,
+                          common_flags()->clear_shadow_mmap_threshold);
+#else
   uptr shadow_beg = MEM_TO_SHADOW(aligned_beg);
   uptr shadow_end = MEM_TO_SHADOW(
       aligned_beg + aligned_size - SHADOW_GRANULARITY) + 1;
@@ -46,10 +51,6 @@
   // probably provide higher-level interface for these operations.
   // For now, just memset on Windows.
   if (value || SANITIZER_WINDOWS == 1 ||
-      // TODO(mcgrathr): Fuchsia doesn't allow the shadow mapping to be
-      // changed at all.  It doesn't currently have an efficient means
-      // to zero a bunch of pages, but maybe we should add one.
-      SANITIZER_FUCHSIA == 1 ||
       // RTEMS doesn't have have pages, let alone a fast way to zero
       // them, so default to memset.
       SANITIZER_RTEMS == 1 ||
@@ -72,6 +73,7 @@
       ReserveShadowMemoryRange(page_beg, page_end - 1, nullptr);
     }
   }
+#endif
 }
 
 ALWAYS_INLINE void FastPoisonShadowPartialRightRedzone(


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64166.207911.patch
Type: text/x-patch
Size: 1599 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190703/9c5711d0/attachment.bin>