[PATCH] D64135: [lit] Parse command-line options from LIT_OPTS

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 15:46:04 PDT 2019


jdenny added a comment.

In D64135#1569395 <https://reviews.llvm.org/D64135#1569395>, @probinson wrote:

> lit has options?


:-)

> If this works when running llvm-lit.py as well as ninja check-foo, I can see it being handy for those (rare at least for me) occasions when a lit option is what you want.  And it looks pretty cheap.

Lately, I most often use `-vv` (so I can see the line number of a failed RUN command) and `-a` (so I can verify the passing tests are doing what I expect).

> Re tests, I don't see why you have 4, wouldn't 2 be sufficient? Given that 2, 3, and 4 are identical.

Good point.  Actually, 1 is probably enough for what I actually mean to test.  I'll adjust soon.

Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64135/new/

https://reviews.llvm.org/D64135





More information about the llvm-commits mailing list