[PATCH] D64117: [WebAssembly][NFC] simplify SjLj inline assembly test

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 15:25:36 PDT 2019


aheejin added a comment.

In D64117#1567697 <https://reviews.llvm.org/D64117#1567697>, @aheejin wrote:

> Hmm right, every other function has `hidden`... while you're on a roll, can you remove all `hidden`s here? :) Thanks!


Friendly ping. Next time, if you don't want to make some changes I suggested, could you please not just ignore it but rather let me know why you don't want that? This is really nothing, so I'm not asking you to upload this in a separate patch or anything so nevermind about this, but I noticed this pattern a few times now, so I'd just mention this. Thanks for the bugfix again.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64117/new/

https://reviews.llvm.org/D64117





More information about the llvm-commits mailing list