[PATCH] D63949: [PGO] Add profile instrumentation sampling support

Rong Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 14:39:54 PDT 2019


xur added a comment.

In D63949#1569175 <https://reviews.llvm.org/D63949#1569175>, @davidxl wrote:

> Does the bursty style sampling provide additional benefit? A non-bursty style sampling can be cheaper:
>
> sample_count++;
>  if (sample_count == SamplePeriod) {
>
>   increment_prof_counter();
>    sample_count = 0;
>
> }


This is the only implementation that I had done. I can implement a pure sampling method and compare the performance.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63949/new/

https://reviews.llvm.org/D63949





More information about the llvm-commits mailing list