[PATCH] D63850: [AMDGPU] Kernel arg metadata: added support for "__hip_texture" type.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 14:34:13 PDT 2019


jdoerfert added a comment.

In D63850#1569264 <https://reviews.llvm.org/D63850#1569264>, @rampitec wrote:

> Both tests fail with compiler crashing. Must always check hasName() before using getName().
>  I believe this needs to be reverted, this change will not work anyway if name was stripped, which llvm does.


Especially Release builds strip all unnecessary names.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63850/new/

https://reviews.llvm.org/D63850





More information about the llvm-commits mailing list