[PATCH] D64099: [InstCombine] pow(C,x) -> exp2(log2(C)*x)
Dávid Bolvanský via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 3 12:53:16 PDT 2019
xbolva00 added a comment.
In D64099#1569028 <https://reviews.llvm.org/D64099#1569028>, @evandro wrote:
> Since using `exp2(log())` was mathematically incorrect, have you run any benchmark that validates the results, such SPEC CPU2006 or CPU2017? If so, what kind of improvement did it register?
I tested the first patch and the second revision with change to exp2 locally with simple examples to check for correctness and performance - and yes, I didn’t check previous revision with folding so a mistake was made.
I have no access to the SPEC benchmarks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64099/new/
https://reviews.llvm.org/D64099
More information about the llvm-commits
mailing list