[PATCH] D63672: Added Delta IR Reduction Tool

Wed Jul 3 11:02:48 PDT 2019

diegotf marked 2 inline comments as done.
diegotf added a comment.

In D63672#1568616 <https://reviews.llvm.org/D63672#1568616>, @dblaikie wrote:

> In D63672#1567614 <https://reviews.llvm.org/D63672#1567614>, @diegotf wrote:
>
> > In D63672#1565680 <https://reviews.llvm.org/D63672#1565680>, @dblaikie wrote:
> >
> > > Did the broader design discussion about bugpoint lead to this design (a separate llvm-reduce tool)? I didn't quite follow that thread far enough to see the conclusion that lead to this direction (rather than improving/modifying bugpoint) - might be worth writing a bit more in the commit description about the conversation (link to the thread if that's helpful) and design choices - and long-term plan (to merge behavior, share things, remove one or the other - or should these two tools exist indefinitely with different goals/uses?)
> >
> >
> > Thanks for the comment, I've clarified it in the description. As well as a brief description of how the tool is structured.
>
>
> The intent is to build this separately, then fold it into bugpoint? What's the tradeoff/motivation for that compared to building this into bugpoint to begin with? (seems like it presents a risk that that unification doesn't happen & we're left with a fractured solution ('one more competing standard' sort of situation)) Is the desire to get this reviewed/committed sooner while pursuing some bugpoint refactoring necessary before unification, without delaying implementation of this tool until after that refactoring?

The main reason I chose this route was to not interfere with bugpoint's current users, especially because there's low test coverage, these changes might end up doing more harm than good. Additionally, some community members also voiced their concerns about how the redesign might affect their current workflow.

I also agree the risks you mentioned are very real indeed, and I'm not still 100% sure this might be the best approach so other routes might be worth exploring.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63672/new/

https://reviews.llvm.org/D63672