[PATCH] D64111: Add getMostFrequentByte and use for isBytewiseValue implementation

Wed Jul 3 10:06:11 PDT 2019

bjope added a comment.

In D64111#1568670 <https://reviews.llvm.org/D64111#1568670>, @vitalybuka wrote:

> In D64111#1568642 <https://reviews.llvm.org/D64111#1568642>, @bjope wrote:
>
> > What is the idea here? Just a refactoring to get rid of recursive calls? Or are you going to use the histogram for some other purposes?
> >  (the patch is lacking description, but perhaps it's just a temporary hack an not something that is subject for submitting?)
>
>
> Added comment into description, I hope to upload the patch which is going to use new function today.
>
> > FWIW, downstream we have 16-bit addressable units and we are tweaking isBytewiseValue to also support "16-bit bytes" in our fork. So far it has been quite simple to do such adjustments, and maybe it will be doable by using a 65536+1 entries large histogram as well.
> >  I just got curious to what the plan is here (to understand if it is worth spending time on continuing to adapt to the upstream changes or if we simply should keep our current version that should be working for 16-bit splats).
>
> I don't plan other changes in this code after this patch stack.

Ok. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64111/new/

https://reviews.llvm.org/D64111