[PATCH] D63923: [Loop Peeling] Enable peeling for loops with multiple exits

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: lib/Transforms/Utils/LoopUnrollPeel.cpp:65
+static cl::opt<bool>
+UnrollPeelMultiExit("unroll-peel-multi-exit", cl::init(true), cl::Hidden,
+                    cl::desc("Allow peeling of loops with multiple exits."));
----------------
skatkov wrote:
> reames wrote:
> > Submit disabled, then enable in future commit?
> > 
> > And maybe you want a three way choice: none, deopt-only, all?
> Sure, will change to false.
> 
> I do not support the non deopt-only now in terms of update of branch weights. So introducing the explicit difference between deopt-only and all is not what I think make sense.
I think it would be good for the naming to somehow reflect that we do not support any multi-exit loop, but just a very restricted set. The current naming/description sounds more general than the actual implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63923/new/

https://reviews.llvm.org/D63923