[llvm] r365025 - [X86][SSE] LowerINSERT_VECTOR_ELT - ensure insertion index correctness. NFCI.

[Simon Pilgrim via llvm-commits]

Author: rksimon
Date: Wed Jul  3 03:59:52 2019
New Revision: 365025

URL: http://llvm.org/viewvc/llvm-project?rev=365025&view=rev
Log:
[X86][SSE] LowerINSERT_VECTOR_ELT - ensure insertion index correctness. NFCI.

Assert that the insertion index is in range and use uint64_t for the index to fix MSVC/cppcheck truncation warning.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=365025&r1=365024&r2=365025&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Wed Jul  3 03:59:52 2019
@@ -17094,7 +17094,8 @@ SDValue X86TargetLowering::LowerINSERT_V
   if (!isa<ConstantSDNode>(N2))
     return SDValue();
   auto *N2C = cast<ConstantSDNode>(N2);
-  unsigned IdxVal = N2C->getZExtValue();
+  assert(N2C->getAPIntValue().ult(NumElts) && "Out of range element index");
+  uint64_t IdxVal = N2C->getZExtValue();
 
   bool IsZeroElt = X86::isZeroNode(N1);
   bool IsAllOnesElt = VT.isInteger() && llvm::isAllOnesConstant(N1);