[PATCH] D64079: Scalable Vector IR Type (Try 3)

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 23:56:57 PDT 2019


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: lib/IR/Verifier.cpp:700
+  if (auto *VTy = dyn_cast<VectorType>(GV.getValueType()))
+    if (VTy->isScalable())
+      CheckFailed("Globals cannot contain scalable vectors", &GV);
----------------
nit: you can use the Assert macro as a shorthand:
`Assert(!VTy->isScalable(), "Globals cannot contain scalable vectors", &GV);`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64079/new/

https://reviews.llvm.org/D64079





More information about the llvm-commits mailing list