[PATCH] D64061: Force check prof branch_weights consistency in SwitchInstProfUpdateWrapper

Tue Jul 2 21:50:22 PDT 2019

yrouban added a comment.

In D64061#1566956 <https://reviews.llvm.org/D64061#1566956>, @davidxl wrote:

> What types of testing has been done ? I assume the code base now is relatively clean so it is safe to turn this on by default?

Frankly speaking I'm not 100% sure that the code is safe. There could be projects that might hit the assertion. E.g I have to fix one pass internally at Azul. I tested LLVM monorepo make check-all and our Azul Zing test suits. So, I believe that the only way to find issues is to land this check D64061 <https://reviews.llvm.org/D64061> and the verifyer D61179 <https://reviews.llvm.org/D61179> one by one with some reasonable interval (one week?).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64061/new/

https://reviews.llvm.org/D64061