[PATCH] D64101: [LoopUnroll] fix cloning callbr

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 18:10:39 PDT 2019


nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:99
+          I->setOperand(
+              OpNo, BlockAddress::get(static_cast<BasicBlock *>(&*It->second)));
+      }
----------------
Sorry, I think this should be a `dyn_cast` (we're "downcasting" from a Value* to a BasicBlock*, which may fail)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64101/new/

https://reviews.llvm.org/D64101





More information about the llvm-commits mailing list