[PATCH] D59343: [WebAssembly] Add option to emit passive segments

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Nice!



================
Comment at: lld/wasm/Driver.cpp:479
+      // is called from __wasm_call_ctors before the user-level constructors.
+      // We also unconditionally export
       WasmSym::ApplyRelocs = Symtab->addSyntheticFunction(
----------------
The last line of this comment doesn't seem to be full sentence and is inaccurate so perhaps remove that line while you are here?


================
Comment at: lld/wasm/Writer.cpp:640
+static void CreateFunction(DefinedFunction *Func,
+                           const std::string &BodyContent) {
+  std::string FunctionBody;
----------------
Take a `StringRef` rather than `const string&`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59343/new/

https://reviews.llvm.org/D59343