[PATCH] D64115: [WebAssembly] Prevent inline assembly from being mangled by SjLj

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 17:33:30 PDT 2019


tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:964
       const Value *Callee = CI->getCalledValue();
-      if (!canLongjmp(M, Callee))
+      if (!canLongjmp(M, Callee) || isa<InlineAsm>(Callee))
         continue;
----------------
sbc100 wrote:
> tlively wrote:
> > Please add a comment about why InlineAsm needs to be skipped.
> Why move this into calLongjmp?
That seems like a good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64115/new/

https://reviews.llvm.org/D64115





More information about the llvm-commits mailing list