[PATCH] D64101: [LoopUnroll] fix cloning callbr

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 17:26:59 PDT 2019


nickdesaulniers marked an inline comment as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LoopUnroll.cpp:91
+  if (isa<CallBrInst>(*I))
+    for (unsigned OpNo = 0, E = I->getNumOperands(); OpNo != E; ++OpNo) {
+      // ... whose operand was a block address ...
----------------
Notes to reviewers: let me know if the comments are excessive and I'll remove them.

Also note that I manually peeled this loop out from the above in this function.  I could place the `isa<CallBrInst>` and rest of this block in there.  Just let me know WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64101/new/

https://reviews.llvm.org/D64101





More information about the llvm-commits mailing list