[PATCH] D63877: Avoid infinite loop with asan interception

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 15:19:15 PDT 2019


vitalybuka added inline comments.


================
Comment at: compiler-rt/test/asan/TestCases/dlopen-mixed-c-cxx.c:2
+// RUN: %clangxx_asan -xc++ -shared -fPIC -o %t.so - < %s
+// RUN: %clang_asan -fsanitize=address %s -o %t.out -ldl
+// RUN: ASAN_OPTIONS=verbosity=1 not %t.out %t.so 2>&1 | FileCheck %s
----------------
kcc wrote:
> Do you need -fsanitize=address here? 
It's marked as done, but I don't see a difference


================
Comment at: compiler-rt/test/asan/TestCases/dlopen-mixed-c-cxx.c:33
+  int (*bar)(void);
+  void *handle = dlopen(argv[1], RTLD_LAZY);
+  assert(handle);
----------------
Test uses dlopen, so it should go into Linux, or Posix


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63877/new/

https://reviews.llvm.org/D63877





More information about the llvm-commits mailing list